-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate driver and test driver codebases #397
Conversation
13148a7
to
c778880
Compare
cc @trxcllnt |
Yeah, I tried with installing directly into the conda env and everything works with just |
This PR moves all of the test driver code in
nv-legate/cumeric
down into this repo tolegate.tester
. Where possible classes and functions that were similar or duplicated between the two were moved into a new legate.util` module.Downstream changes
The changes required to have Cunumeric's
test.py
work are given below. I will make a corresponding PR there that also removes the old tester codebase there as well.It's possible (likely) that the tester code will need to be generalized, especially with respect to the ability to specify test locations and files maybe even types of test. I think its best to keep this PR simple and wait until we want to add a concrete second project for testing, and generalize based on those requirements.
Self-testing
The new submodules in legate core have ~1220 tests. I would like to get these running in CI at some point. These tests can be run with "plain" pytest, I think that is important otherwise the test code is testing itself in a sense.