Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed incorrect conversion from rotation matrix to quaternion #73

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chaojie-fu
Copy link

assigning signs to x, y, z and w was executed multiple times in function quat_from_rotation_matrix, which is inconsistent with that was described in reference (http://www.cg.info.hiroshima-cu.ac.jp/~miyazaki/knowledge/teche52.html). And it made the conversion incorrect.

For example, for rotation matrix [[-0.87, -0.50, 0.00], [0.00, 0.00, 1.00], [-0.50, 0.87, 0.00]], the corresponding quatenion is [0.18, 0.68, 0.68, -0.18] ([w, x, y, z]), while the function gives [0.18, 0.68, 0.68, 0.18].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant