fix(path): Windows parent root directory #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Windows, doing `Path:new("C:\\Users"):parents()` resulted in a
getting `C:` as one of its parents which is not a valid path. All valid
paths in Windows, Linux, Mac must have at least one path separator.
jamestrew
changed the title
|
@Conni2461 following up 🙏 |
|
I reported a related issue in May. This will probably fix that, too. |
|
It would be great if we could get this fix in. This issue breaks some critical functionality in Obsidian.nvim for Windows users. |
|
i cant confirm that this actually fixes issues on windows, but it seems like it doesnt introduce regressions for linux, so lets give this a try. Thanks for the fix james :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Windows, doing
Path:new("C:\\Users"):parents()results in a gettingC:as one of its parents which is not a valid path. All valid paths in Windows, Linux, Mac must have at least one path separator.Partially fixes nvim-telescope/telescope-file-browser.nvim#285