-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/audio overhaul #191
Conversation
…ing out the PCM data
In other places in the code this nil check does not happen, so presumably it is innefective.
JS has been spiked and it looks like one needs to use AudioWorklets (https://developer.mozilla.org/en-US/docs/Web/API/AudioWorkletNode) to handle audio like we want to, with a streaming interface. The instructions for doing this revolve around having multiple js files that load each other as classes, which I don't know how to do with syscall/js, if it's even possible. |
… feature/audio-overhaul
Codecov Report
@@ Coverage Diff @@
## master #191 +/- ##
==========================================
- Coverage 92.67% 92.26% -0.42%
==========================================
Files 141 141
Lines 6406 6438 +32
==========================================
+ Hits 5937 5940 +3
- Misses 407 435 +28
- Partials 62 63 +1
Continue to review full report at Codecov.
|
Darwin can also use our pulse implementation (or our jfreymuth/pulse wrapper, to be less generous)-- and personally I prefer that requirement to the other roads one would need to go down, i.e. compiling more C / C variants to interact with osx specific audio libraries. |
Current thought is to do:
Then merge this in and cut a minor release bump for it. |
(JS audio can't follow this API as syscall js currently works and android audio basically only works with OpenAL by my understanding, both of which are worth working on but neither worth holding back this branch). |
Other than the todo with the early return the only other thing of note that I see is the unlimited draw rate change. |
Changelog:
|
Issues to open after this is merged and released:
Or maybe this is just a "big audio overhaul" issue with these points as sub goals? |
@Implausiblyfun Objection to merging this and cutting oak 3.4.0? |
See #189, and also #131, although the latter is not done yet
Before this is merged, the new audio system should have implementations for (or spiked and failed for):