Run mypy on all files including tests #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #142 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 544 546 +2
Branches 67 67
=========================================
+ Hits 544 546 +2
Continue to review full report at Codecov.
|
|
Hey sorry, mind rebasing? |
Running mypy on test files helps to ensure the tests are representative by using correct types for APIs. It also could help to expose mistakes in tests with improper use of values.
|
No problem. Done in latest revision. |
REestwick
pushed a commit
to REestwick/pypinfo
that referenced
this pull request
Apr 1, 2024
Running mypy on test files helps to ensure the tests are representative by using correct types for APIs. It also could help to expose mistakes in tests with improper use of values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running mypy on test files helps to ensure the tests are representative
by using correct types for APIs. It also could help to expose mistakes
in tests with improper use of values.