fabtests/fi_dgram_waitset: remove test (deprecated feature)

fi_wait_open and fi_wait are deprecated in 2.0 Signed-off-by: Alexia Ingerson <alexia.ingerson@intel.com>
ofiwg · Sep 13, 2024 · caa8026 · caa8026
1 parent ca9f385
commit caa8026
Show file tree

Hide file tree

Showing 11 changed files with 1 addition and 222 deletions.
diff --git a/fabtests/Makefile.am b/fabtests/Makefile.am
@@ -22,7 +22,6 @@ bin_PROGRAMS = \
 	functional/fi_rdm_deferred_wq \
 	functional/fi_dgram \
 	functional/fi_mcast \
-	functional/fi_dgram_waitset \
 	functional/fi_rdm_tagged_peek \
 	functional/fi_cq_data \
 	functional/fi_poll \
@@ -297,10 +296,6 @@ functional_fi_mcast_SOURCES = \
 	functional/mcast.c
 functional_fi_mcast_LDADD = libfabtests.la
 
-functional_fi_dgram_waitset_SOURCES = \
-	functional/dgram_waitset.c
-functional_fi_dgram_waitset_LDADD = libfabtests.la
-
 functional_fi_rdm_tagged_peek_SOURCES = \
 	functional/rdm_tagged_peek.c
 functional_fi_rdm_tagged_peek_LDADD = libfabtests.la
@@ -624,7 +619,6 @@ dummy_man_pages = \
 	man/man1/fi_cm_data.1 \
 	man/man1/fi_cq_data.1 \
 	man/man1/fi_dgram.1 \
-	man/man1/fi_dgram_waitset.1 \
 	man/man1/fi_inj_complete.1 \
 	man/man1/fi_mcast.1 \
 	man/man1/fi_msg.1 \

diff --git a/fabtests/Makefile.win b/fabtests/Makefile.win
@@ -78,7 +78,7 @@ benchmarks: $(outdir)\dgram_pingpong.exe $(outdir)\msg_bw.exe \
 	$(outdir)\rdm_bw.exe $(outdir)\rdm_tagged_pingpong.exe $(outdir)\rma_bw.exe
 
 functional: $(outdir)\av_xfer.exe $(outdir)\bw.exe $(outdir)\cm_data.exe $(outdir)\cq_data.exe \
-	$(outdir)\dgram.exe $(outdir)\dgram_waitset.exe $(outdir)\msg.exe $(outdir)\msg_epoll.exe \
+	$(outdir)\dgram.exe $(outdir)\msg.exe $(outdir)\msg_epoll.exe \
 	$(outdir)\inject_test.exe $(outdir)\msg_sockets.exe $(outdir)\multi_mr.exe \
 	$(outdir)\multi_ep.exe $(outdir)\multi_recv.exe $(outdir)\poll.exe $(outdir)\rdm.exe \
 	$(outdir)\rdm_atomic.exe $(outdir)\rdm_multi_client.exe $(outdir)\rdm_rma_event.exe \
@@ -128,8 +128,6 @@ $(outdir)\cq_data.exe: {functional}cq_data.c $(basedeps)
 
 $(outdir)\dgram.exe: {functional}dgram.c $(basedeps)
 
-$(outdir)\dgram_waitset.exe: {functional}dgram_waitset.c $(basedeps)
-
 $(outdir)\msg.exe: {functional}msg.c $(basedeps)
 
 $(outdir)\msg_epoll.exe: {functional}msg_epoll.c $(basedeps)

diff --git a/fabtests/fabtests.vcxproj b/fabtests/fabtests.vcxproj
@@ -227,7 +227,6 @@
     <ClCompile Include="ubertest\test_ctrl.c" />
     <ClCompile Include="functional\cq_data.c" />
     <ClCompile Include="functional\dgram.c" />
-    <ClCompile Include="functional\dgram_waitset.c" />
     <ClCompile Include="functional\msg.c" />
     <ClCompile Include="functional\msg_epoll.c" />
     <ClCompile Include="functional\msg_netdir.c" />

diff --git a/fabtests/fabtests.vcxproj.filters b/fabtests/fabtests.vcxproj.filters
@@ -81,9 +81,6 @@
     <ClCompile Include="functional\dgram.c">
       <Filter>Source Files\functional</Filter>
     </ClCompile>
-    <ClCompile Include="functional\dgram_waitset.c">
-      <Filter>Source Files\functional</Filter>
-    </ClCompile>
     <ClCompile Include="functional\msg.c">
       <Filter>Source Files\functional</Filter>
     </ClCompile>

diff --git a/fabtests/functional/dgram_waitset.c b/fabtests/functional/dgram_waitset.c
diff --git a/fabtests/man/fabtests.7.md b/fabtests/man/fabtests.7.md
@@ -50,9 +50,6 @@ features of libfabric.
 *fi_dgram*
 : A basic datagram endpoint example.
 
-*fi_dgram_waitset*
-: Transfers datagrams using waitsets for completion notification.
-
 *fi_inj_complete*
 : Sends messages using the FI_INJECT_COMPLETE operation flag.
 

diff --git a/fabtests/pytest/default/test_dgram.py b/fabtests/pytest/default/test_dgram.py
@@ -12,12 +12,6 @@ def test_dgram(cmdline_args):
     test = ClientServerTest(cmdline_args, "fi_dgram")
     test.run()
 
-@pytest.mark.functional
-def test_dgram_waitset(cmdline_args):
-    from common import ClientServerTest
-    test = ClientServerTest(cmdline_args, "fi_dgram_waitset")
-    test.run()
-
 @pytest.mark.parametrize("iteration_type",
                          [pytest.param("short", marks=pytest.mark.short),
                           pytest.param("standard", marks=pytest.mark.standard)])

diff --git a/fabtests/scripts/runfabtests.sh b/fabtests/scripts/runfabtests.sh
@@ -108,7 +108,6 @@ functional_tests=(
 	"fi_cq_data -e rdm -o writedata"
 	"fi_cq_data -e dgram -o writedata"
 	"fi_dgram"
-	"fi_dgram_waitset"
 	"fi_msg"
 	"fi_msg_epoll"
 	"fi_msg_sockets"

diff --git a/fabtests/test_configs/efa/efa-neuron.exclude b/fabtests/test_configs/efa/efa-neuron.exclude
@@ -69,9 +69,6 @@ cmatose
 # shared AV isn't supported
 shared_av
 
-# wait isn't supported
-dgram_waitset
-
 # Remove this once ubertest supports setting MR modes
 ubertest
 

diff --git a/fabtests/test_configs/efa/efa.exclude b/fabtests/test_configs/efa/efa.exclude
@@ -74,9 +74,6 @@ cmatose
 # shared AV isn't supported
 shared_av
 
-# wait isn't supported
-dgram_waitset
-
 # Remove this once ubertest supports setting MR modes
 ubertest
 

diff --git a/fabtests/test_configs/psm3/psm3.exclude b/fabtests/test_configs/psm3/psm3.exclude
@@ -15,6 +15,5 @@ scalable_ep
 shared_av
 rdm_cntr_pingpong
 multi_recv
-dgram_waitset
 multinode
 rdm_tagged_peek