-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prov/efa, fabtests/efa: Only test inter_min_read_write_size for for emulated write path #10411
Conversation
ba86026
to
230ffbc
Compare
02c8f98
to
54622cb
Compare
AWS CI failure is real
Need to fix |
9817513
to
d84773f
Compare
if HAVE_EFADV | ||
prov_efa_src_fi_efa_rdma_checker_SOURCES = \ | ||
prov/efa/src/efa_rdma_checker.c | ||
prov_efa_src_fi_efa_rdma_checker_LDADD = libfabtests.la |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's dubious to me whether LDADD
is needed.
Reading https://www.gnu.org/software/automake/manual/html_node/Linking.html I think we can do prov_efa_src_fi_efa_rdma_checker_LDFLAGS = -lefa
and get rid of configure.m4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call out, It works for me. I added LDFLAGS and dropped 6901162.
This code checks whether efa device support rdma read or write capability. Signed-off-by: Shi Jin <sjina@amazon.com>
The env inter_min_read_write_size only applies to emulated write path. If the efa device supports RDMA write, device RDMA write will always be used. Signed-off-by: Shi Jin <sjina@amazon.com>
…rite is on FI_EFA_INTER_MIN_READ_WRITE_SIZE is only applied to emulated write protocols. When efa device supports rdma write, rdma write should always be used. Signed-off-by: Shi Jin <sjina@amazon.com>
d84773f
to
04a765c
Compare
@shijin-aws While I was reviewing that one the power went out. Good to see it has been dropped. |
FI_EFA_INTER_MIN_READ_WRITE_SIZE is only applied to emulated write protocols. When efa device support rdma write,
rdma write will be always used.
This PR introduces a efa_rdma_checker.c code to check efa device's rdma read/write capability on a given platform, and
skip inter_min_read_write_size test in fabtests if the device support rdma-write.