prov/lpp: Address coverity scan issues #10438
Open
+47
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Address coverity scan issues in LPP and lpp_regression fabtest. Signed-off-by: Tadeusz Struk <tstruk@gigaio.com>
j-xiong
reviewed
Oct 8, 2024
| @@ -233,7 +234,7 @@ static void *info_server_thread(void *arg) | |||
|
|
|||
| int info_server_sock = setup_server(info_server_port); | |||
|
|
|||
| while (1) { | |||
| while (server_running) { | |||
There was a problem hiding this comment.
sever_running is set to 1 before the thread is created and never set to 0. What's the difference from the old code?
There was a problem hiding this comment.
This is just to stop the coverity complaining about dead code after the while loop.
|
bot:aws:retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address coverity scan issues in LPP and lpp_regression fabtest.