prov/gni: allow NULL desc in read|write{v,msg} #6593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Libfabric allows relaxed enforcement of local MR registration thus the user can choose to skip local buffer registration when issuing an RMA. The current code, however, requires a pointer to a NULL pointer for such a case, which is inconvenient to user. This patch allows a NULL pointer to be directly passed. Signed-off-by: Min Si <msi@anl.gov>
|
I tested the patch with MPICH on NERSC/Cori. I don't know if there is a standalone libfabric test suite that need to be tested. Could you please explain the testing method to me if I need to run more tests offline? |
This was referenced Feb 24, 2021
|
@hppritcha -- can you review this PR? |
|
@jswaro - This PR might be relevant to you as well. |
hppritcha
approved these changes
Apr 3, 2021
|
looks good to me. not sure about the travis problem. |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Libfabric allows relaxed enforcement of local MR registration thus the user can choose to skip local buffer registration when issuing an RMA. The current code, however, requires a pointer to a NULL pointer for such a case, which is inconvenient to user. This patch allows a NULL pointer to be directly passed.
Background about why we propose this change:
msg.desc=NULLwhen usingfi_readmsg|writemsg.descis not provided by user but it still requires a non-NULLdescto be passed (e.g.,desc[0] = NULL). It will be more convenient to user if it accepts aNULLpointer directly.I don't see a clear description in the spec about the required format of
descfield instruct fi_msg_rma. Please let me know if our usage is wrong. We need to figure out a consistent way to specify NULL desc that can be supported by all providers.