strip leading delimiter character when trimming tags #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handles the case where a user may begin typing a tag with a delimiter character followed by any number of spaces. Without checking for and replacing a leading delimiter character the tag will not be trimmed as expected.
adamgruber
force-pushed
the
strip-leading-delimiter
branch
from
64894f8
to
77caa6f
Compare
|
@okcoker Any chance you could look at this sometime this week? Would love to get this fix in to address some customer issues. |
|
@adamgruber surely! re running the travis build now |
|
Need to figure out the build problem but the tests pass locally. Thanks for the PR 👍 |
|
Thanks for the merge and quick response! |
|
Any plans to cut a new version with this change? If you've got other blockers for releasing maybe I can help out? |
|
@adamgruber just published 1.14.2. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles the case where a user may begin typing a tag with a delimiter character followed by any number of spaces. Without checking for and replacing a leading delimiter character the tag will not be trimmed as expected.
Alternate approach to the issue raised in #140 but doesn't rely on preventing default.