Changes for the OpenSpout Excel export #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Truncate the value when it is larger than the Excel cell limit * Do not wrap text * Decode HTML encoded characters in the value
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #356 +/- ##
==========================================
+ Coverage 94.56% 94.60% +0.04%
==========================================
Files 37 37
Lines 975 983 +8
==========================================
+ Hits 922 930 +8
Misses 53 53 ☔ View full report in Codecov by Sentry. |
|
I'm not sure about the PHPStan failure. It seems unrelated to my PR. Could you look into it? |
|
@curry684 can you please review & merge? Tnx :) |
curry684
approved these changes
Oct 4, 2024
|
Oops, bit too busy moving offices 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of small changes to the OpenSpout exporter from #332.
Alvast bedankt voor het ernaar kijken :)