Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

websteps: changes to the oddity model #2034

Closed
3 tasks
bassosimone opened this issue Feb 22, 2022 · 1 comment
Closed
3 tasks

websteps: changes to the oddity model #2034

bassosimone opened this issue Feb 22, 2022 · 1 comment
Assignees
Labels
2024-01-data-quality-cleanup Data quality issues addressed on 2024-01 data quality enhancement improving existing code or new feature methodology issues related to the testing methodology ooni/probe-engine priority/medium user feedback requests that have been added to the backlog as a direct result of user feedback or testing wontfix when an issue won't be addressed (add a comment to the issue as to why this is the case)

Comments

@bassosimone
Copy link
Contributor

bassosimone commented Feb 22, 2022

This issue is about changing how the oddity model integrates with websteps. There are actually three set of changes here, and they are described below. We can close this issue once we have implemented these changes.

  • terminology changes
  • data model issues
  • complexity issues

Let me summarize what each of these set of changes is about below.

Terminology changes It seems more natural to think in terms of expected / unexpected than to think in terms of oddities. What is currently named evidence could be hard evidence. What is currently named clue could be soft evidence.

Also, "noise" does not seem like a good term to use here. Better to use "unexplained".

Data model issues It seems more natural to radically separate observations from interpretations. So, if the oddity idea survives this round of feedback, it should in any case be in another data structure that is separated from the observation structure.

Complexity issues Adding the oddity as another level of abstraction on top of the failure complicates understanding the data. So, this begs the question of whether instead the oddity should be some internal value used to simplify computing an overall result.

This specific issue is directly to address feedback that @fortuna and @ohnorobo provided to me when I discussed websteps' design with them.

@bassosimone bassosimone added enhancement improving existing code or new feature priority/medium user feedback requests that have been added to the backlog as a direct result of user feedback or testing methodology issues related to the testing methodology data quality ooni/probe-engine labels Feb 22, 2022
@bassosimone bassosimone self-assigned this Feb 22, 2022
bassosimone added a commit to ooni/spec that referenced this issue May 9, 2022
See ooni/probe#2091 (issue) and ooni/probe-cli#717 (impl).

While there, ensure we remove the `oddity` from the JSON examples, since it's non standard and most likely we're going to remove oddities after community feedback (see ooni/probe#2034).
@bassosimone bassosimone added the wontfix when an issue won't be addressed (add a comment to the issue as to why this is the case) label Jan 25, 2024
@bassosimone
Copy link
Contributor Author

bassosimone commented Jan 25, 2024

I am not going to do this because websteps and the oddity model are not happening soon. That said, I adopted the expected / unexpected terminology suggested by @fortuna and @ohnorobo, thank you!

@bassosimone bassosimone added the 2024-01-data-quality-cleanup Data quality issues addressed on 2024-01 label Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2024-01-data-quality-cleanup Data quality issues addressed on 2024-01 data quality enhancement improving existing code or new feature methodology issues related to the testing methodology ooni/probe-engine priority/medium user feedback requests that have been added to the backlog as a direct result of user feedback or testing wontfix when an issue won't be addressed (add a comment to the issue as to why this is the case)
Projects
None yet
Development

No branches or pull requests

1 participant