Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for previous / submit buttons should explicitly test for presence/absence of a button based on configuration. #400

Open
svenvandescheur opened this issue Apr 20, 2023 · 0 comments
Assignees

Comments

@svenvandescheur
Copy link
Contributor

#399 (comment)

sergei-maertens added a commit that referenced this issue May 24, 2023
* Due to the custom react-router Link component, more components need to be
  wrapped in a proper Router context
* Updated react-dom.render calls to react-dom.createRoot

The act() warnings are something we'll have to live with for now, they don't
seem obvious on how to fix, and most of these tests should be rewritten to use
testing-library/react instead anyway. See #400
sergei-maertens added a commit that referenced this issue May 24, 2023
* Due to the custom react-router Link component, more components need to be
  wrapped in a proper Router context
* Updated react-dom.render calls to react-dom.createRoot

The act() warnings are something we'll have to live with for now, they don't
seem obvious on how to fix, and most of these tests should be rewritten to use
testing-library/react instead anyway. See #400
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants