Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/4717 accessibility improvements aria tags #719

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

robinmolen
Copy link
Contributor

@robinmolen robinmolen commented Oct 10, 2024

Closes open-formulieren/open-forms#4717

Some accessibility improvements involving aria tags, role's and textual alternatives:

  • The Loader element now has a textual alternative, which will be translated.
  • The modals now use html buttons as buttons (instead of icons with a button role).
  • The delete button/link for an file now specifies which file will be removed.
  • And finally alerts now have role="alert".

@robinmolen robinmolen linked an issue Oct 10, 2024 that may be closed by this pull request
3 tasks
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.42%. Comparing base (ee809c9) to head (8db4908).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #719      +/-   ##
==========================================
- Coverage   77.56%   77.42%   -0.15%     
==========================================
  Files         233      233              
  Lines        4752     4775      +23     
  Branches     1283     1302      +19     
==========================================
+ Hits         3686     3697      +11     
- Misses       1033     1045      +12     
  Partials       33       33              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robinmolen robinmolen force-pushed the feature/4717-accessibility-improvements-aria-tags branch from 7fa1958 to 8db4908 Compare October 10, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessibility improvements - Aria tags
1 participant