This repository has been archived by the owner on Sep 30, 2022. It is now read-only.
Fix misc warnings and missing include files #1000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(back-ported from commit open-mpi/ompi@64b6956)
this bug was introduced in open-mpi/ompi@64b6956 Thanks Pavel (Pasha) Shamis for reporting this issue (cherry picked from commit open-mpi/ompi@0fb7b07)
(cherry picked from commit open-mpi/ompi@4f8c0c5)
(cherry picked from commit open-mpi/ompi@e8d347d)
(cherry picked from commit open-mpi/ompi@80bdbfd)
ggouaillardet
changed the title
|
Test PASSed. |
| @@ -235,10 +239,14 @@ opal_progress_event_users_increment(void) | |||
| void | |||
| opal_progress_event_users_decrement(void) | |||
| { | |||
| #if OPAL_ENABLE_DEBUG || ! OPAL_PROGRESS_USE_TIMERS | |||
There was a problem hiding this comment.
Is this second conditional (!OPAL_PROGRESS_USE_TIMERS) correct?
There was a problem hiding this comment.
it looks correct to me, we only need val in order to print it (e.g. OPAL_ENABLE_DEBUG) or a few lines later if ! OPAL_PROGRESS_USE_TIMERS
|
It seems like there are more than just warnings fixes in here, and there are some actual bug fixes, too. |
|
@rhc54 Can you have a look at this one? |
|
👍 |
jsquyres
added a commit
that referenced
this pull request
Mar 8, 2016
Fix misc warnings and missing include files
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:bot:assign: @rhc54
:bot:milestone:v2.0.0
:bot🏷️Code-cleanup-low-priority