Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part comm tests #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

adrielpoo
Copy link

No description provided.

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Hello! The Git Commit Checker CI bot found a few problems with this PR:

5077fad: Update README.md

  • check_signed_off: does not contain a valid Signed-off-by line

dbf9692: Update README.md

  • check_signed_off: does not contain a valid Signed-off-by line

f651f4f: Initial part comm test

  • check_signed_off: does not contain a valid Signed-off-by line

9e73608: Initial part comm test

  • check_signed_off: does not contain a valid Signed-off-by line

c638cfc: Initial part comm test

  • check_signed_off: does not contain a valid Signed-off-by line

5940bf3: Initial part comm tests

  • check_signed_off: does not contain a valid Signed-off-by line

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

@jsquyres
Copy link
Member

jsquyres commented Aug 9, 2023

@adrielpoo Is this materially different than what you had in #27?

A few suggestions:

  1. You can probably squash these commits down to a single commit.
  2. Per the bot messages, you need to sign off your commit message. See https://docs.open-mpi.org/en/main/developers/git-github.html#git-commits-open-source-contributor-s-declaration.
  3. Can you make the C code adhere to https://docs.open-mpi.org/en/main/developers/source-code.html#code-style? (we have a pretty short coding style / not many elements to adhere to -- should be easy to update, e.g., via indent(1) or somesuch)

@jsquyres jsquyres mentioned this pull request Aug 9, 2023
@adrielpoo
Copy link
Author

@adrielpoo Is this materially different than what you had in #27?

A few suggestions:

1. You can probably squash these commits down to a single commit.

2. Per the bot messages, you need to sign off your commit message.  See https://docs.open-mpi.org/en/main/developers/git-github.html#git-commits-open-source-contributor-s-declaration.

3. Can you make the C code adhere to https://docs.open-mpi.org/en/main/developers/source-code.html#code-style? (we have a pretty short coding style / not many elements to adhere to -- should be easy to update, e.g., via `indent(1)` or somesuch)

@adrielpoo Is this materially different than what you had in #27?

A few suggestions:

1. You can probably squash these commits down to a single commit.

2. Per the bot messages, you need to sign off your commit message.  See https://docs.open-mpi.org/en/main/developers/git-github.html#git-commits-open-source-contributor-s-declaration.

3. Can you make the C code adhere to https://docs.open-mpi.org/en/main/developers/source-code.html#code-style? (we have a pretty short coding style / not many elements to adhere to -- should be easy to update, e.g., via `indent(1)` or somesuch)

Thanks so much for the advice, I am currently trying to squash the commits and do the sign off thanks for the link. I will look at the code style and adapt it.

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Hello! The Git Commit Checker CI bot found a few problems with this PR:

5077fad: Update README.md

  • check_signed_off: does not contain a valid Signed-off-by line

dbf9692: Update README.md

  • check_signed_off: does not contain a valid Signed-off-by line

f651f4f: Initial part comm test

  • check_signed_off: does not contain a valid Signed-off-by line

9e73608: Initial part comm test

  • check_signed_off: does not contain a valid Signed-off-by line

c638cfc: Initial part comm test

  • check_signed_off: does not contain a valid Signed-off-by line

5940bf3: Initial part comm tests

  • check_signed_off: does not contain a valid Signed-off-by line

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

Initial part comm test

Initial part comm test

Initial part comm test

Update README.md

Update README.md

Part Comm Unit Test

Signed-off-by: Adriel Poo Armas <poo.adriel07@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants