Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coll/cuda: always compile component #11529

Merged

Conversation

edgargabriel
Copy link
Member

the coll/cuda component has been converted to use the accelerator framework. Hence, we can always compile it, no need for the configure logic.
Furthemore, the component will now disqualify itself if the accelerator component selected is the 'null' component.

the coll/cuda component has been converted to use the accelerator
framework. Hence, we can always compile it, no need for the configure
logic.
Furthemore, the component will now disqualify itself if the accelerator
component selected is the 'null' component.

Signed-off-by: Edgar Gabriel <Edgar.Gabriel@amd.com>
@edgargabriel
Copy link
Member Author

bot:ibm:retest

@wckzhang
Copy link
Contributor

Should we be renaming the component? Also due to delayed initialization, the accelerator component can still have the cuda component selected even if the user isn't going to use cuda. I don't know if that matters here, but that's something to consider whenever we have this check

opal_accelerator_base_selected_component.base_version.mca_component_name,
                    "null"

@edgargabriel
Copy link
Member Author

@wckzhang I wouldn't rename the component right now, that is a much more intrusive change than what I intended with this commit. I need to look however into the lazy initialization aspect, I haven't thought of that. Thanks!

@janjust
Copy link
Contributor

janjust commented Apr 20, 2023

@edgargabriel @wckzhang can this be merged? Is it good to go, and do we want to cherry-pick this to v5.0?

@edgargabriel
Copy link
Member Author

@janjust I don't think this is a candidate for the 5.0 release. Maybe we could discuss it in the meeting next Tuesday, I am a bit nervous about removing the configure logic. It is strictly speaking not required anymore, but the component would suddenly be available in all builds, and I would like to make sure that there is community agreement on how to approach this.

@hppritcha hppritcha requested review from hppritcha and removed request for wckzhang May 9, 2023 15:19
@edgargabriel edgargabriel requested a review from janjust May 23, 2023 17:23
@janjust janjust merged commit 8185faf into open-mpi:main Jun 1, 2023
@edgargabriel edgargabriel deleted the topic/coll-cuda-accelerator-fix branch July 12, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants