opal/accelerator: implement additional stub APIs #12091
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change implements stub APIs introduced in open-mpi#10959 Signed-off-by: Wenduo Wang <wenduwan@amazon.com>
|
i'll double check this on ANL sunspot. |
|
I would suggest to hold back merging this, I realized something yesterday afternoon and want to discuss it with @wenduwan first |
|
@edgargabriel and I had a brief conversation about #10959 We missed the existing constructor-destructor mechanism implemented by William. If we follow this convention then we can possibly avoid having explicit destroy* APIs, which applies to:
We would like to re-evaluate the use case(especially in ZE @hppritcha ). For now I will revert #10959 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change implements stub APIs introduced in
#10959