pmix/external: revamp external pmix package detection

[ggouaillardet]

No description provided.

[jsquyres]

@ggouaillardet Please remove all the commented-out lines (vs. commenting them out). Thanks.

[jsquyres]

bot:retest

[jsquyres]

@Di0gen I see a bunch of these errors in the Mellanox Jenkins output -- can you fix?

./jenkins_scripts/jenkins/ompi/ompi_jenkins.sh: line 217: [: missing `]'

[ggouaillardet]

oops, will do

[jsquyres]

@ggouaillardet In open-mpi/ompi-release#1118 (comment), you mentioned that PMIx uses more than one include directory. Can you set CPPFLAGS before calling OPAL_CHECK_PACKAGE?

[ggouaillardet]

@jsquyres This is no more needed !

[jsquyres]

Ok.

[rhc54]

👎

This isn't correct - please read the comment about why we cannot use check_package

[rhc54]

👍

[rhc54]

Please bring over to 2.0 - blocker over there

[rhc54]

Unrelated issues again.

[jjhursey]

FWIW I did something similar in this #1583 - checkout the additional logic to opal_check_pmi.m4. It worked with external hwloc and libevent in non-standard locations.

Of course, there I was also extracting the version - which we don't need for this commit.

[jladd-mlnx]

@jsquyres @rhc54 Hmm...I'm concerned about this. Looks like the first time the Mellanox Jenkins breaks in mindist mapper is with this PR. All subsequent PRs on master are failing. I'll try to investigate more today.

[jsquyres]

@jladd-mlnx Is the Mellanox Jenkins using an external pmix installation?

[jsquyres]

@jladd-mlnx I just turned this mindist problem into its own issue: #1623. Let's followup there.