ompi/comm: refactor communicator cid code #1855
Conversation
|
This is looking good but it seems to be running into a pmix bug. Once I determine what the bug is I will update this PR. |
|
#1881 Seems to have fixed the hangs fro intercommunicators. Running a few more tests then will remove the DNM. |
hjelmn
force-pushed
the
comm_rework
branch
3 times, most recently
from
d8ea15a
to
fc4685e
Compare
This commit simplifies the communicator context ID generation by removing the blocking code. The high level calls: ompi_comm_nextcid and ompi_comm_activate remain but now call the non-blocking variants and wait on the resulting request. This was done to remove the parallel paths for context ID generation in preperation for further improvements of the CID generation code. Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
|
Build Failed with XL compiler! Please review the log, and get in touch if you have questions. Gist: https://gist.github.com/71621f4a3dff38eebacf24c690a6c04f |
|
Build Failed with GNU compiler! Please review the log, and get in touch if you have questions. Gist: https://gist.github.com/a7bda16558f104841951fdb0ff6d54db |
|
IBM CI system experiencing some connectivity issues at the moment. Will retest once the system comes back online. |
|
@jjhursey Alright, will wait on merging this one until IBM's jenkins is back up. |
|
bot:ibm:retest |
This commit simplifies the communicator context ID generation by
removing the blocking code. The high level calls: ompi_comm_nextcid
and ompi_comm_activate remain but now call the non-blocking variants
and wait on the resulting request. This was done to remove the
parallel paths for context ID generation in preperation for further
improvements of the CID generation code.
Signed-off-by: Nathan Hjelm hjelmn@lanl.gov