-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2.x: Improve x86-64 timer performance #3748
Conversation
I found an interesting reading on this issue (http://akaros.cs.berkeley.edu/lxr/akaros/kern/arch/x86/rdtsc_test.c). We might want to have a reference on it somewhere. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matcabral Can you please put the "cherry picked from" notations in the commits? You should be able to use the -x
option to git cherry-pick
to have git automatically put those in there for you.
This helps us track what has gone over from master to the release branches.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes in opal/runtime/opal_progress.c are good. I have added a comment regarding the lack of documentation on why lfence+rdtsc is a better approach. |
@bosilca Thanks for the sanity check. 👍 |
@hjelmn please double check this PR. |
porting PR #2926 to v2.x