Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix osc sm posts when only 32 bit atomics support #6803

Merged
merged 1 commit into from
Aug 28, 2019

Conversation

guserav
Copy link
Contributor

@guserav guserav commented Jul 9, 2019

No description provided.

@ompiteam-bot
Copy link

Can one of the admins verify this patch?

Signed-off-by: guserav <erik.zeiske@hpe.com>
@guserav guserav force-pushed the fix-osc-sm-post-32-bit-atomics branch from c84f83c to 3c9f4e6 Compare July 9, 2019 22:14
@bosilca
Copy link
Member

bosilca commented Jul 9, 2019

ok to test.

Copy link
Member

@jsquyres jsquyres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bosilca @hjelmn This looks like a small, no-brainer fix to me. Can you please take a quick look? If not, we'll merge on 3 Sep 2019. Thanks!

@jsquyres
Copy link
Member

Need to check and see if this affects any release branches -- @guserav guesses offhand that it probably affects at least the v4.0.x branch.

@guserav
Copy link
Contributor Author

guserav commented Aug 27, 2019

In v2.x and v3.0.x it just assumes that 64 bit atomics work, also another atomic is used (so this patch wont apply anyway)
It seems like 7cdda24 has introduced the problem.
So v3.1.x and v4.0.x have the problem

@hjelmn hjelmn merged commit c4d0752 into open-mpi:master Aug 28, 2019
@guserav guserav deleted the fix-osc-sm-post-32-bit-atomics branch August 29, 2019 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants