Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configury: fix --disable-io-romio option #8607

Merged
merged 1 commit into from
Mar 15, 2021

Conversation

ggouaillardet
Copy link
Contributor

do not build 3rd-party/romio321 if ROMIO is disabled

Signed-off-by: Gilles Gouaillardet gilles@rist.or.jp

do not build 3rd-party/romio321 if ROMIO is disabled

Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp>
@ggouaillardet
Copy link
Contributor Author

FWIW, if Open MPI is configure'd with --disable-io-romio, then make dist will not include 3rd-party/romio321.
That being said, this is the similar behavior as before (and in the release branches < 5)

@ggouaillardet ggouaillardet merged commit e604107 into open-mpi:master Mar 15, 2021
@awlauria
Copy link
Contributor

@ggouaillardet can you cherry-pick back to v5.0.x when you get a chance?

@jsquyres
Copy link
Member

Do we really need the --disable-io-romio option any more? I.e., isn't this now redundant with --enable-mca-no-build=io-romio?

@awlauria
Copy link
Contributor

@ggouaillardet ping can you cherry-pick this to v5.0.x when you have time.

Thanks.

@ggouaillardet
Copy link
Contributor Author

ggouaillardet commented Mar 30, 2021

@awlauria done (#8737)

btw, when is 5.0 expected?
I would really like to have ROMIO updated before it is released
(I first need time to refresh an outdated #8343)

@awlauria
Copy link
Contributor

@ggouaillardet no specific date yet, anticipated sometime this summer. The sooner we can get the romio update in the better though.

@ggouaillardet
Copy link
Contributor Author

@awlauria Thanks, I just issued #8740, that should leave enough time to properly test and cherry-pick for 5.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants