-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shields_Arylation #57
Shields_Arylation #57
Conversation
Shields Arylation S42 and S45. Paper: https://doi.org/10.1038/s41586-021-03213-y Best, Jesus
I merged into the main branch, but the check is failing. Which branch in the repo should I merge to? Best, |
uploading the zip files. |
That check is ok to fail; I'll change the target branch when we're ready to merge. The Submission/process_submission check is the important one. A couple things:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for the most part. Couple things:
- The vessel type given is
WELL_PLATE
, which is true, though the reactions are actually set up inVIAL
s of materialGLASS
in a well plate, not in the plate wells directly. @skearnes @connorcoley, don't know that we've discussed this yet. How should this be captured? Also, the pressure control is listed asSEALED
, but noVesselAttachment
is listed. I assume the vials are capped, which can be captured by adding aCAP
VesselAttachment
; please add this. - There is only one workup step (
ALIQUOT
) included, which contains string details describing several more steps. The full workup is described as:
The plate was removed from the glovebox, opened, and diluted to a 900 uL total volume with N,N-dimethylacetamide. The plate was stirred for 5 min and a 75 uL sample was taken and filtered into an HPLC analysis plate. The filter was rinsed with 400 uL acetonitrile/water (4:1) solution and analyzed by UHPLCMS.
This should be captured by the full workup step sequence: ADDITION
-> STIRRING
-> ALIQUOT
-> FILTRATION
-> ADDITION
.
- The
INTERNAL_STANDARD
is listed in a separatereaction.outcome
, though it is analyzed in the sameanalyses
key as the desired product. This can be captured by adding the internal standard to the set of products in the first (and only) outcome. Its peak areameasurement
can also be added and linked to the sameUHPLCMS
analysis that the product is measured with. These values are not included in the dataset, only the ultimate processed reaction yields. I don't know that this is necessarily a problem (@skearnes @connorcoley?), but do you have the raw peak areas for the internal standard?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thanks for working through this, Jesus!
* Shields_Arylation (#57) * Shields_Arylation Shields Arylation S42 and S45. Paper: https://doi.org/10.1038/s41586-021-03213-y Best, Jesus * Delete Shields_arylation_42.pbtxt * Delete experiment_index_extended_dataset (1).pbtxt * Upload pbtxt * Delete experiment_index_S42_dataset (1).pbtxt * Delete experiment_index_extended_dataset (1).pbtxt * Add files via upload * Update submission * Update badges Co-authored-by: Jesus00-1 <75488893+Jesus00-1@users.noreply.github.com> Co-authored-by: github-actions <github-actions@github.com>
Shields Arylation S42 and S45. Paper: https://doi.org/10.1038/s41586-021-03213-y
Best,
Jesus