Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shields_Arylation #57

Merged
merged 8 commits into from
Mar 4, 2021

Conversation

Jesus00-1
Copy link
Contributor

Shields Arylation S42 and S45. Paper: https://doi.org/10.1038/s41586-021-03213-y

Best,
Jesus

Shields Arylation S42 and S45. Paper: https://doi.org/10.1038/s41586-021-03213-y

Best,
Jesus
@Jesus00-1
Copy link
Contributor Author

I merged into the main branch, but the check is failing. Which branch in the repo should I merge to?

Best,
Jesus

@Jesus00-1
Copy link
Contributor Author

uploading the zip files.

experiment_index_extended.zip
experiment_index_S42.zip

@skearnes
Copy link
Contributor

skearnes commented Feb 8, 2021

I merged into the main branch, but the check is failing. Which branch in the repo should I merge to?

Best,
Jesus

That check is ok to fail; I'll change the target branch when we're ready to merge. The Submission/process_submission check is the important one.

A couple things:

Copy link
Contributor

@michaelmaser michaelmaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the most part. Couple things:

  1. The vessel type given is WELL_PLATE, which is true, though the reactions are actually set up in VIALs of material GLASS in a well plate, not in the plate wells directly. @skearnes @connorcoley, don't know that we've discussed this yet. How should this be captured? Also, the pressure control is listed as SEALED, but no VesselAttachment is listed. I assume the vials are capped, which can be captured by adding a CAP VesselAttachment; please add this.
  2. There is only one workup step (ALIQUOT) included, which contains string details describing several more steps. The full workup is described as:

The plate was removed from the glovebox, opened, and diluted to a 900 uL total volume with N,N-dimethylacetamide. The plate was stirred for 5 min and a 75 uL sample was taken and filtered into an HPLC analysis plate. The filter was rinsed with 400 uL acetonitrile/water (4:1) solution and analyzed by UHPLCMS.

This should be captured by the full workup step sequence: ADDITION -> STIRRING -> ALIQUOT -> FILTRATION -> ADDITION.

  1. The INTERNAL_STANDARD is listed in a separate reaction.outcome, though it is analyzed in the same analyses key as the desired product. This can be captured by adding the internal standard to the set of products in the first (and only) outcome. Its peak area measurement can also be added and linked to the same UHPLCMS analysis that the product is measured with. These values are not included in the dataset, only the ultimate processed reaction yields. I don't know that this is necessarily a problem (@skearnes @connorcoley?), but do you have the raw peak areas for the internal standard?

@skearnes skearnes changed the base branch from main to #57 March 4, 2021 16:34
@skearnes skearnes closed this Mar 4, 2021
@skearnes skearnes reopened this Mar 4, 2021
Copy link
Contributor

@michaelmaser michaelmaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for working through this, Jesus!

@skearnes skearnes merged commit 99699b9 into open-reaction-database:#57 Mar 4, 2021
skearnes added a commit that referenced this pull request Mar 4, 2021
* Shields_Arylation (#57)

* Shields_Arylation

Shields Arylation S42 and S45. Paper: https://doi.org/10.1038/s41586-021-03213-y

Best,
Jesus

* Delete Shields_arylation_42.pbtxt

* Delete experiment_index_extended_dataset (1).pbtxt

* Upload pbtxt

* Delete experiment_index_S42_dataset (1).pbtxt

* Delete experiment_index_extended_dataset (1).pbtxt

* Add files via upload

* Update submission

* Update badges

Co-authored-by: Jesus00-1 <75488893+Jesus00-1@users.noreply.github.com>
Co-authored-by: github-actions <github-actions@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants