Make gzip reproducible #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #560 +/- ##
==========================================
- Coverage 76.29% 76.27% -0.03%
==========================================
Files 19 19
Lines 1911 1909 -2
Branches 468 467 -1
==========================================
- Hits 1458 1456 -2
Misses 305 305
Partials 148 148
|
connorcoley
approved these changes
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
open-reaction-database/ord-data#64 is stuck in an infinite loop because gzip encodes the modification time (see mtime). This PR sets a constant
mtimein message_helpers.write_message to make repeated writes to the same file reproducible. Note that the filename is also encoded, so repeated writes to different files will not have identical bytes.