[exporter/elasticsearch] handle ecs mode mapping #29742
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
andrzej-stencel
added a commit
that referenced
this pull request
May 7, 2024
….mode: ecs` (#31694) **Description:** <Describe what has changed.> This PR is a follow up to #31553. In that PR, the foundations were laid for encoding log records with ECS fields when the user specifies `mapping.mode: ecs` in their exporter configuration. This PR adds ECS conversions for several additional fields. I expect there will be more followup PR(s) to add more conversions, especially ones that might not be straightforward. **Link to tracking issue:** #29742 **Testing:** Added unit tests **Documentation:** The `mapping.mode: ecs` configuration setting is already [documented](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/exporter/elasticsearchexporter#configuration-options). --------- Co-authored-by: Andrzej Stencel <andrzej@andrzejstencel.pl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Initial pass in implementing the
ecsmapping mode that is documented but not implemented. This only covers a small subset of attribute mappings from otel > ecs, but the core record fields should be properly mapped.Link to tracking Issue:
Testing:
Added test for ecs mapping mode.
Documentation:
Updated the documentation to reflect the default behavior is the current behavior with no mapping applied.