Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore]: move aggregation logic to internal module #33669

Merged
merged 6 commits into from
Jul 2, 2024

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Jun 20, 2024

Description:

  • duplicated and enhanced aggregation business logic (with median function) for common usage in follow-up tickets
  • tests

Link to tracking Issue: #16224

Follow-ups:

@odubajDT odubajDT changed the title chore: move aggregation logic to internal/coreinternal chore[internal/core]: move aggregation logic to internal/coreinternal Jun 20, 2024
@odubajDT odubajDT changed the title chore[internal/core]: move aggregation logic to internal/coreinternal [internal/core]: move aggregation logic to internal/coreinternal Jun 20, 2024
@odubajDT odubajDT changed the title [internal/core]: move aggregation logic to internal/coreinternal [internal/core]: move aggregation logic to internal module Jun 21, 2024
@odubajDT odubajDT marked this pull request as ready for review June 21, 2024 08:56
@odubajDT odubajDT requested review from a team and crobert-1 June 21, 2024 08:56
@crobert-1 crobert-1 added processor/metricstransform Metrics Transform processor processor/transform Transform processor labels Jun 21, 2024
@crobert-1
Copy link
Member

Adding processor/transform and processor/metricstransform labels as those are the intended components using or intending to be used with this functionality.

.chloggen/aggregate-move.yaml Outdated Show resolved Hide resolved
@odubajDT odubajDT changed the title [internal/core]: move aggregation logic to internal module chore: move aggregation logic to internal module Jul 2, 2024
@odubajDT odubajDT changed the title chore: move aggregation logic to internal module [chore]: move aggregation logic to internal module Jul 2, 2024
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@evan-bradley evan-bradley merged commit e85efb3 into open-telemetry:main Jul 2, 2024
154 checks passed
@github-actions github-actions bot added this to the next release milestone Jul 2, 2024
dmitryax pushed a commit that referenced this pull request Jul 22, 2024
#33655)

**Description:**
- use aggregation business logic from `interval/core`
- support `median` aggregation type
- testing
- docs

**Link to tracking Issue:** #16224 

**Depends on**
#33669

---------

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
evan-bradley added a commit that referenced this pull request Jul 29, 2024
…metrics (#33334)

**Link to tracking Issue:** #16224 

**Changes:**

- implemented `aggregate_on_attributes` function (supporting
sum/min/max/mean/median) for Sum, Gauge, Histogram, ExponentialHistogram
- tests
- documentation

**Depends on**
#33669

---------

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
TylerHelmuth pushed a commit that referenced this pull request Sep 6, 2024
… for metrics (#33423)

**Link to tracking Issue:** #16224 

**Changes:**

- implemented `aggregate_on_attribute_value` function
- tests
- documentation

**Depends on**
#33669

---------

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
f7o pushed a commit to f7o/opentelemetry-collector-contrib that referenced this pull request Sep 12, 2024
… for metrics (open-telemetry#33423)

**Link to tracking Issue:** open-telemetry#16224 

**Changes:**

- implemented `aggregate_on_attribute_value` function
- tests
- documentation

**Depends on**
open-telemetry#33669

---------

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal/core processor/metricstransform Metrics Transform processor processor/transform Transform processor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants