Skip to content

Commit

Permalink
Set OTEL_EXPORTER_OTLP_METRICS_ENDPOINT needed for Java agent (#237)
Browse files Browse the repository at this point in the history
* Set OTEL_EXPORTER_OTLP_METRICS_ENDPOINT needed for Java agent

* Remove unneeded line + add Changelog

Co-authored-by: Austin Parker <austin@ap2.io>
  • Loading branch information
dineshg13 and austinlparker committed Aug 2, 2022
1 parent 30689db commit fb5d741
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .env
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ COLLECTOR_ZIPKIN_HOST_PORT=:9411
# Collector
OTEL_EXPORTER_OTLP_TRACES_ENDPOINT=http://otelcol:4317
OTEL_EXPORTER_OTLP_ENDPOINT=${OTEL_EXPORTER_OTLP_TRACES_ENDPOINT}
OTEL_EXPORTER_OTLP_METRICS_ENDPOINT=${OTEL_EXPORTER_OTLP_TRACES_ENDPOINT}

# Load Generator
USERS=10
Expand Down Expand Up @@ -55,4 +56,4 @@ FEATURE_FLAG_GRPC_SERVICE_PORT=50053
PROMETHEUS_SERVICE_PORT=9090

# Grafana
GRAFANA_SERVICE_PORT=3000
GRAFANA_SERVICE_PORT=3000
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,3 +41,5 @@ significant modifications will be credited to OpenTelemetry Authors.
([#189](https://github.com/open-telemetry/opentelemetry-demo/pull/189))
* Simplified repo name and dropped the '-webstore' suffix in every place
([#225](https://github.com/open-telemetry/opentelemetry-demo/pull/225))
* Add metrics endpoint in adservice to send metrics from java agent
([#237](https://github.com/open-telemetry/opentelemetry-demo/pull/237))
1 change: 1 addition & 0 deletions docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ services:
environment:
- AD_SERVICE_PORT
- OTEL_EXPORTER_OTLP_TRACES_ENDPOINT
- OTEL_EXPORTER_OTLP_METRICS_ENDPOINT
- OTEL_RESOURCE_ATTRIBUTES=service.name=adservice
depends_on:
- otelcol
Expand Down
Binary file modified src/adservice/agent/opentelemetry-javaagent.jar
Binary file not shown.

0 comments on commit fb5d741

Please sign in to comment.