update cpp and pin to 3.18 #1296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puckpuck
approved these changes
Dec 13, 2023
2 tasks
syscl
pushed a commit
to deductive-ai/opentelemetry-demo
that referenced
this pull request
Jan 24, 2024
Pulled two commits from main in order to fix currency service build failure: - open-telemetry/pull/1335 - - open-telemetry/pull/1296 - Pin alpine to 3.18 - C++ 1.13.0 is being used by dependent libraries, so C++ version was updated Both of these changes are required to remain compatible with [open-telemetry/opentelemetry-cpp](https://github.com/open-telemetry/opentelemetry-cpp) --------- Signed-off-by: Pierre Tessier <pierre@pierretessier.com> Co-authored-by: Pierre Tessier <pierre@pierretessier.com> Co-authored-by: Juliano Costa <julianocosta89@outlook.com> Co-authored-by: Petr Styblo <styblope@gmail.com>
jmichalak9
pushed a commit
to jmichalak9/opentelemetry-demo
that referenced
this pull request
Mar 22, 2024
mrasu
added a commit
to mrasu/echoed
that referenced
this pull request
Mar 23, 2024
currencyservice was not able to build c.f. * open-telemetry/opentelemetry-demo#1275 * open-telemetry/opentelemetry-demo#1296
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the currencyservice build failure; We also need to update some flags to handle the updated protobuf libraries.