[paymentservice] add basic metrics support #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyang
approved these changes
Nov 15, 2022
|
@pichlermarc would you mind updating our metric feature matrix too? Lgtm otherwise. Thanks for this! |
|
Oh and we'll need to update the payment service doc in the docs/services folder |
fatsheep9146
approved these changes
Nov 16, 2022
|
@cartersocha changed some text to the payment service docs to reflect the new setup, added some text for metrics, and changed the entry in the matrix 🙂 |
mviitane
reviewed
Nov 16, 2022
mviitane
approved these changes
Nov 16, 2022
|
Thanks again @pichlermarc! Merging now |
jmichalak9
pushed a commit
to jmichalak9/opentelemetry-demo
that referenced
this pull request
Mar 22, 2024
* [paymentservice] add basic metrics support * add changelog add changelog * update docs * fix typos. * fix linting errors * clarify 'wrapper' approach Co-authored-by: Carter Socha <43380952+cartersocha@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #68
Changes
This PR adds a counter
app.payment.transactionsthat can be split by the transaction currency, adds dependencies to the JS Metrics packages, and changes the startup process so that the async resource detection can finish before creating aMeterorTracer.Once updated instrumentation packages are released, I will open a follow-up PR that updates the metrics API/SDK to the GA versions. Then the added temporality environment variable will also change the temporality of the exported metrics accordingly. 🙂