Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(frontend): adding synthetic attribute flag to FE instrumentation #631

Conversation

xoscar
Copy link
Contributor

@xoscar xoscar commented Dec 12, 2022

Changes

This PR includes a new span attribute coming from the FE instrumentation when triggering a fetch request to the API endpoints.

Merge Requirements

For new features contributions please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs folder

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@xoscar xoscar requested a review from a team December 12, 2022 18:09
@puckpuck
Copy link
Contributor

@xoscar I know it's the holidays so you may not get this, but when you get a chance please update the branch so we can get this one merged.

In the future, if you do a PR from your personal fork instead of an organizational one, we can update the branch for you.

@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@xoscar
Copy link
Contributor Author

xoscar commented Jan 2, 2023

@puckpuck makes sense! I'll start doing that, thanks for the feedback! 😄

@julianocosta89 julianocosta89 merged commit 40f9f61 into open-telemetry:main Jan 2, 2023
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
…ion (open-telemetry#631)

* feature(frontend): adding synthetic attribute flag to FE instrumentation

* feature(frontend): adding frontend documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants