Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[blog] Spring starter stable #4937

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

[blog] Spring starter stable #4937

wants to merge 29 commits into from

Conversation

zeitlinger
Copy link
Member

@zeitlinger zeitlinger commented Aug 2, 2024 •
edited
Loading

@zeitlinger zeitlinger self-assigned this Aug 2, 2024
@github-actions github-actions bot added the blog label Aug 2, 2024
@opentelemetrybot opentelemetrybot requested a review from a team August 2, 2024 12:29
@zeitlinger zeitlinger marked this pull request as ready for review August 2, 2024 12:34
@zeitlinger zeitlinger requested a review from a team August 2, 2024 12:34
@cartermp cartermp changed the title Spring starter stable [blog] Spring starter stable Aug 2, 2024
@cartermp
Copy link
Contributor

cartermp commented Aug 2, 2024

/fix:all

@opentelemetrybot
Copy link
Collaborator

You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/10217010164

theletterf
theletterf approved these changes Aug 5, 2024
View reviewed changes
Copy link
Member

@theletterf theletterf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Added some suggestions.

content/en/blog/2024/spring-starter-stable/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/spring-starter-stable/index.md Show resolved Hide resolved
content/en/blog/2024/spring-starter-stable/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/spring-starter-stable/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/spring-starter-stable/index.md Show resolved Hide resolved
zeitlinger and others added 2 commits August 5, 2024 10:53
@zeitlinger @svrnm
Update content/en/blog/2024/spring-starter-stable/index.md
1350f22 
Co-authored-by: Severin Neumann <neumanns@cisco.com>
@zeitlinger @theletterf
Update content/en/blog/2024/spring-starter-stable/index.md
d8c7c1d 
Co-authored-by: Fabrizio Ferri-Benedetti <fferribenedetti@splunk.com>
@opentelemetrybot opentelemetrybot requested a review from a team August 5, 2024 08:54
@zeitlinger
Copy link
Member Author

I'm wondering if we should add an image?

@theletterf
Copy link
Member

@zeitlinger An image? Tell me more!

@zeitlinger
Copy link
Member Author

@zeitlinger An image? Tell me more!

something to catch the eye
I don't have an idea what would be interesting

@theletterf
Copy link
Member

@zeitlinger Oh, not needed in my opinion (though the temptation of adding a DALL-E generated picture is strong these days).

svrnm
svrnm reviewed Aug 9, 2024
View reviewed changes
content/en/blog/2024/spring-starter-stable/index.md
---
title: The OpenTelemetry Spring Boot starter is now stable
linkTitle: Spring Starter GA
date: 2024-
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
date: 2024-
date: 2024-

@zeitlinger any timelines for publishing this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in about a month - if possible I'd like to have the micrometer explanation be published before

@trask fyi

@zeitlinger @svrnm
Update content/en/blog/2024/spring-starter-stable/index.md
293b38c 
Co-authored-by: Severin Neumann <neumanns@cisco.com>
@opentelemetrybot opentelemetrybot requested a review from a team August 9, 2024 08:40
zeitlinger
zeitlinger commented Sep 17, 2024
View reviewed changes
Copy link
Member Author

@zeitlinger zeitlinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great 😄

content/en/blog/2024/spring-starter-stable/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/spring-starter-stable/index.md Show resolved Hide resolved
content/en/blog/2024/spring-starter-stable/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/spring-starter-stable/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/spring-starter-stable/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/spring-starter-stable/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/spring-starter-stable/index.md Show resolved Hide resolved
content/en/blog/2024/spring-starter-stable/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/spring-starter-stable/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/spring-starter-stable/index.md Outdated Show resolved Hide resolved
jeanbisutti and others added 9 commits September 17, 2024 10:09
@jeanbisutti @zeitlinger
Update content/en/blog/2024/spring-starter-stable/index.md
a7514b9 
Co-authored-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
@jeanbisutti @zeitlinger
Update content/en/blog/2024/spring-starter-stable/index.md
adbe3c4 
Co-authored-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
@jeanbisutti @zeitlinger
Update content/en/blog/2024/spring-starter-stable/index.md
6917a0d 
Co-authored-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
@jeanbisutti @zeitlinger
Update content/en/blog/2024/spring-starter-stable/index.md
d015863 
Co-authored-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
@jeanbisutti @zeitlinger
Update content/en/blog/2024/spring-starter-stable/index.md
3cbf048 
Co-authored-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
@jeanbisutti @zeitlinger
Update content/en/blog/2024/spring-starter-stable/index.md
474a6f5 
Co-authored-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
@jeanbisutti @zeitlinger
Update content/en/blog/2024/spring-starter-stable/index.md
681a782 
Co-authored-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
@jeanbisutti
2.7.0 => 2.8.0
e8bde00
@jeanbisutti
Update index.md
dd597b8
zeitlinger
zeitlinger commented Sep 17, 2024
View reviewed changes
content/en/blog/2024/spring-starter-stable/index.md Outdated
Testing across different versions of Spring Boot is no easy task, especially
when you add GraalVM to the mix.

But maybe more interesting is the fact that we learned how to create interfaces
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zeitlinger add an example

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. how to configure sdk with values
  2. how to customize with spring beans

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeanbisutti please check

zeitlinger
zeitlinger commented Sep 17, 2024
View reviewed changes
content/en/blog/2024/spring-starter-stable/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/spring-starter-stable/index.md Outdated
Testing across different versions of Spring Boot is no easy task, especially
when you add GraalVM to the mix.

But maybe more interesting is the fact that we learned how to create interfaces
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. how to configure sdk with values
  2. how to customize with spring beans

@zeitlinger @jeanbisutti
Update content/en/blog/2024/spring-starter-stable/index.md
6d3e394 
Co-authored-by: Jean Bisutti <jean.bisutti@gmail.com>
@opentelemetrybot opentelemetrybot requested a review from a team September 19, 2024 07:59
@zeitlinger zeitlinger requested a review from a team as a code owner September 19, 2024 09:49
jeanbisutti
jeanbisutti reviewed Sep 19, 2024
View reviewed changes
content/en/blog/2024/spring-starter-stable/index.md Outdated
<!-- prettier-ignore-end -->

You can also create your own exporter, to
[export spans to memory](https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/1b5d47eadcef33405b3065ff57e9d96bb15d795a/smoke-tests-otel-starter/spring-smoke-testing/src/main/java/io/opentelemetry/spring/smoketest/SpringSmokeOtelConfiguration.java#L50-L63).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This other configuration is also needed to have this metric exporter works: https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/1b5d47eadcef33405b3065ff57e9d96bb15d795a/smoke-tests-otel-starter/spring-smoke-testing/src/main/java/io/opentelemetry/spring/smoketest/SpringSmokeOtelConfiguration.java#L50-L63 If we keep this example, we should mention the two required configurations.

jeanbisutti
jeanbisutti reviewed Sep 19, 2024
View reviewed changes
content/en/blog/2024/spring-starter-stable/index.md Outdated
```
<!-- prettier-ignore-end -->

You can also create your own exporter, to
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the previous example is enough to understand the concept

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svrnm svrnm svrnm left review comments

@cartermp cartermp cartermp left review comments

@jeanbisutti jeanbisutti jeanbisutti left review comments

@theletterf theletterf theletterf approved these changes

Assignees

@zeitlinger zeitlinger

Labels
blog
Projects
SIG Comms: PRs & Issues
Status: Changes Requested
Spring Boot Starter GA
Status: In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

write blog post about spring starter GA
6 participants
@zeitlinger @cartermp @opentelemetrybot @theletterf @svrnm @jeanbisutti