Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker-deployment.md #5167

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

CharlieTLe
Copy link
Contributor

Optimizations on trace-based testing in open-telemetry/opentelemetry-demo#1659 changed how tracetest is enabled. This change updates the documentation to reflect on enabling trace based tests should be done.

Optimizations on trace-based testing in open-telemetry/opentelemetry-demo#1659 changed how tracetest is enabled. This change updates the documentation to reflect on enabling trace based tests should be done.
@CharlieTLe CharlieTLe requested a review from a team September 8, 2024 19:16
@opentelemetrybot opentelemetrybot requested a review from a team September 8, 2024 19:16
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall lgtm, @open-telemetry/demo-approvers PTAL!

@cartermp
Copy link
Contributor

cartermp commented Sep 8, 2024

/fix:all

@opentelemetrybot
Copy link
Collaborator

@opentelemetrybot
Copy link
Collaborator

fix:all was successful.

IMPORTANT: (RE-)RUN /fix:all to ensure that there are no remaining check issues.

@cartermp cartermp added the sig-approval-missing Co-owning SIG didn't provide an approval label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig:demo sig-approval-missing Co-owning SIG didn't provide an approval
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants