Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

criu checkpoint/restore: print errors from criu log #3816

Merged
merged 4 commits into from
Aug 5, 2023
Merged

criu checkpoint/restore: print errors from criu log #3816

merged 4 commits into from
Aug 5, 2023

Commits on Aug 3, 2023

  1. libct: move criu-related stuff to separate file 

    No code change, only added periods to some comments to make godot happy.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    @kolyshkin
    kolyshkin committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    cb981e5 View commit details
    Browse the repository at this point in the history

  2. criuSwrk: simplify switch 

    1. Use "switch t" since we only check t.

2. Remove unneeded t assignment.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    @kolyshkin
    kolyshkin committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    e4478e9 View commit details
    Browse the repository at this point in the history

  3. criu checkpoint/restore: print errors from criu log 

    When criu fails, it does not give us much context to understand what
was the cause of an error -- for that, we need to take a look into its
log file.

This is somewhat complicated to do (as you can see in parts of
checkpoint.bats removed by this commit), and not very user-friendly.

Add a function to find and log errors from criu logs, together with some
preceding context, in case either checkpoint or restore has failed.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    @kolyshkin
    kolyshkin committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    c77aaa3 View commit details
    Browse the repository at this point in the history

  4. criu: do not add log file into error message 

    As we now log the log file name in logCriuErrors.

While at it, there is no need to use var.String() with %s as it is done
by the runtime.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    @kolyshkin
    kolyshkin committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    3867693 View commit details
    Browse the repository at this point in the history