Revert to non-recursive GetPids, add recursive GetAllPids #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jimmi Dyson <jimmidyson@gmail.com>
jimmidyson
force-pushed
the
non-recursive-pids
branch
from
08d32ad
to
91c7024
Compare
|
LGTM. Thanks @jimmidyson! |
|
I've restarted the build. |
|
@jfrazelle There is some issue with the builds. Could you please take a look? Thanks! |
|
nvm, this just turned green :) |
|
LGTM |
LK4D4
added a commit
that referenced
this pull request
Jan 8, 2016
Revert to non-recursive GetPids, add recursive GetAllPids
|
Thanks! Any chance of a tag? |
|
@jimmidyson I want to merge pids cgroup before tagging. |
|
@LK4D4 Is there a PR for that that I can track? |
|
#446? |
|
@jimmidyson Yes. |
stefanberger
pushed a commit
to stefanberger/runc
that referenced
this pull request
Sep 8, 2017
runtime: Drop create-specific API caveat from lifecycle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #457
/cc @LK4D4 @vishh