Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config data types are tied to the build platform #324

Closed
aaronlehmann opened this issue Feb 19, 2016 · 3 comments
Closed

Config data types are tied to the build platform #324

aaronlehmann opened this issue Feb 19, 2016 · 3 comments
Milestone

Comments

@aaronlehmann
Copy link

It's currently not possible to use the specs library to manipulate a Linux container configuration on a different platform, because some of the data types are defined in config_linux.go and runtime_config_linux.go. As a result, the package doesn't even compile on non-Linux platforms:

# github.com/opencontainers/specs
./config.go:26: undefined: User

Varying the data types based on the build target platform doesn't seem like the right approach. It should be possible for a non-architecture-specific tool or client to parse or generate configurations for containers that will eventually run on Linux.

The current approach is also problematic for projects which vendor github.com/opencontainers/specs but still need to support other platforms.

@vbatts
Copy link
Member

vbatts commented Feb 19, 2016

Thanks for the issue. This has been an issue and discussed. I need to dust
off my PR for this.

On Fri, Feb 19, 2016 at 2:04 PM Aaron Lehmann notifications@github.com
wrote:

It's currently not possible to use the specs library to manipulate a Linux
container configuration on a different platform, because some of the data
types are defined in config_linux.go and runtime_config_linux.go. As a
result, the package doesn't even compile on non-Linux platforms:

github.com/opencontainers/specs

./config.go:26: undefined: User

Varying the data types based on the build target platform doesn't seem
like the right approach. It should be possible for a
non-architecture-specific tool or client to parse or generate
configurations for containers that will eventually run on Linux.

The current approach is also problematic for projects which vendor
github.com/opencontainers/specs but still need to support other platforms.


Reply to this email directly or view it on GitHub
#324.

@crosbymichael crosbymichael added this to the v0.4.0 milestone Feb 22, 2016
@wking
Copy link
Contributor

wking commented Feb 22, 2016

On Fri, Feb 19, 2016 at 11:48:54AM -0800, Vincent Batts wrote:

This has been an issue and discussed.

Previous issues are #135 and #166. Close this one in favor of #166?

@vbatts
Copy link
Member

vbatts commented Feb 29, 2016

closing in favor of #166

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants