feat: add Learn path, change menu icons to use the new design #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stackingcats
requested changes
Apr 1, 2021
There was a problem hiding this comment.
Thank you. Looks good in general.
A few concerns:
- Would it be worth the effort to dynamically fetch the videos instead of hard-coding them?
- When navigating to the learn view, I get an error
Failed to execute ‘postMessage’ on ‘DOMWindow’: The target origin provided (‘https://www.youtube.com’) does not match the recipient window’s origin (‘https://localhost:3000’).
and lots of warnings
Some cookies are misusing the recommended “SameSite“ attribute
Please let's wipe those off.
src/stories/ConsoleIcon.stories.tsx
Outdated
| import { Story, Meta } from "@storybook/react/types-6-0"; | ||
|
|
||
| export default { | ||
| title: "ConsoleIcon", |
There was a problem hiding this comment.
Maybe would make sense to group all the menu icons under one story?
Done.
I couldn't find solution to Failed to execute ‘postMessage’ on ‘DOMWindow’ issue, I checked that it is related with youtube iframe get call (tjallingt/react-youtube#96), but not caused by react-youtube library. Also, "Some cookies are misusing the recommended “SameSite“ attribute" is still an issue as well - from what I researched, cookies are controlled from server-side and youtube should take care of cookies itself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Learn path, change menu icons to use the new design. Also, I decided to use inline svg-s for the menu icons, because otherwise I would have needed to use hacky ways to get the hover working (https://css-tricks.com/the-many-ways-to-change-an-svg-fill-on-hover-and-when-to-use-them/).