Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check for cluster_role #16

Merged
merged 1 commit into from
Sep 12, 2022
Merged

Conversation

welteki
Copy link
Member

@welteki welteki commented Sep 12, 2022

Signed-off-by: Han Verstraete (OpenFaaS Ltd) han@openfaas.com

Description

Moves check for cluster_role env variable to operator and faas-netes container.

Motivation and Context

The checker always reported "Pro autoscaler detected, but cluster_role is disabled - unable to collect CPU/RAM metrics" when the autoscaler is enabled.

How Has This Been Tested?

Tested on k3d cluster by deploying OpenFaaS Pro with autoscaler and cluster role enabled and than running the checker. Then repeated the test with the autoscaler enabled but cluster role set to false.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
@alexellis alexellis merged commit ceedf0f into openfaas:master Sep 12, 2022
@welteki welteki deleted the cluster-role branch September 12, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants