Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUU] Fix Table width not responsive to the amount of selected columns #12812

Conversation

chahmedejaz
Copy link
Collaborator

What? Why?

  • Closes [BUU] Table width is not responsive to the amount of selected columns #12809
  • It looks like there was a typo in the class name for the producer in the product row column. As a result, when the producer column is selected as hidden, the variant's producer column hides correctly, but the product's producer column remains visible due to the incorrect class name.
  • This PR fixes this typo

What should we test?

  • Visit the products page
  • Hide any of the Producer and On Hand columns
  • Columns width should remain responsive.

Release notes

Changelog Category (reviewers may add a label for the release notes):

  • User facing changes
  • API changes (V0, V1, DFC or Webhook)
  • Technical changes only
  • Feature toggled

@chahmedejaz chahmedejaz changed the title [BUU] Fix Table width is not responsive to the amount of selected columns [BUU] Fix Table width not responsive to the amount of selected columns Aug 23, 2024
@chahmedejaz chahmedejaz added the bug-s3 The bug is stopping a critical or non-critical feature but there is a usable workaround. label Aug 23, 2024
Copy link
Member

@dacook dacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@drummer83 drummer83 added the pr-staged-au staging.openfoodnetwork.org.au label Aug 28, 2024
@sigmundpetersen sigmundpetersen added the user facing changes Thes pull requests affect the user experience label Aug 28, 2024
@drummer83 drummer83 self-assigned this Aug 28, 2024
@drummer83
Copy link
Contributor

Hi @chahmedejaz,
Thanks for fixing this!

I have tested this on staging AU and created some screenshots to document the behaviour.

Test results

All columns visible:
grafik

Name hidden:
Only Producer column is gaining width.
grafik

On Hand hidden:
Bug is fixed. ✔️
Only Producer and Name columns are gaining width.
grafik

Producer hidden:
Bug is fixed. ✔️
Only Name column is gaining width.
grafik

Any other column hidden:
grafik

Name AND Producer hidden:
Only Image column is gaining width.
grafik

Only name AND Unit visible:
Only name column is gaining width. Unit column is still overflowing.
grafik

Other findings (out of scope here)

  • Name, SKU, Unit, Price, On Hand are not adding ellipsis (...) for overflowing content.
  • Column widths could be organised in a better way. The current approach seems too static.

Conclusion

Great! The bug is fixed! 🎉
Merging! 🚀

@drummer83 drummer83 merged commit 0c2dcbc into openfoodfoundation:master Aug 28, 2024
57 checks passed
@drummer83 drummer83 removed the pr-staged-au staging.openfoodnetwork.org.au label Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-s3 The bug is stopping a critical or non-critical feature but there is a usable workaround. user facing changes Thes pull requests affect the user experience
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUU] Table width is not responsive to the amount of selected columns
4 participants