Add browser unsaved changes modal when navigating from order summary page [OFN-11600] #12836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wandji20
force-pushed
the
wb-OFN-11600
branch
from
5dc3311
to
fbfb429
Compare
chahmedejaz
requested changes
Sep 3, 2024
There was a problem hiding this comment.
Hi @wandji20! Thank you for working on this. I noticed a few minor issues that need attention. Could you please take a look when you have a moment? Thanks so much!
Edit:
The failing specs are unrelated.
wandji20
force-pushed
the
wb-OFN-11600
branch
from
fbfb429
to
481e9d8
Compare
chahmedejaz
approved these changes
Sep 3, 2024
mkllnk
approved these changes
Sep 4, 2024
sigmundpetersen
changed the title
filipefurtad0
force-pushed
the
wb-OFN-11600
branch
from
481e9d8
to
0002b2e
Compare
filipefurtad0
added
pr-staged-fr
|
Hey @wandji20 , I've verified that, when on the /summary page, both as guest and as logged user:
The modal works as expected (confirming closes the page, refusing leave the page open)
Looks great! Merging. |
|
Removing the staged-AU label. I assume you're done here, @filipefurtad0? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Show pop-in alert when navigating away from the summary page without placing an order
What should we test?
Navigating away from the order summary page will now show the default browser popup
With exceptions to
/checkout/summary
Release notes
Show pop-in alert when navigating away from the summary page without placing an order
Changelog Category (reviewers may add a label for the release notes):
Dependencies
N/A
Documentation updates
N/A