Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RVFI - Correcting rvfi trace commit in some corner cases #919

Merged
merged 1 commit into from
Dec 6, 2023
Merged

RVFI - Correcting rvfi trace commit in some corner cases #919

merged 1 commit into from
Dec 6, 2023

Conversation

YoannPruvost
Copy link
Contributor

This PR corrects 2 things in RVFI:

  • It removes an expired workaround to handle ebreak
  • It only flag an instruction as illegal if the core is decoding

@YoannPruvost YoannPruvost added the Component:Verif For issues in the verification environment or test cases (e.g. for testbench, C code, etc.) label Dec 6, 2023
@davideschiavone davideschiavone merged commit 61423d9 into openhwgroup:dev Dec 6, 2023
3 checks passed
@YoannPruvost YoannPruvost deleted the dev_ypr_better_rvfi_commit branch January 12, 2024 06:35
@YoannPruvost YoannPruvost restored the dev_ypr_better_rvfi_commit branch January 12, 2024 06:35
@YoannPruvost YoannPruvost deleted the dev_ypr_better_rvfi_commit branch January 12, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davideschiavone davideschiavone davideschiavone approved these changes

Assignees

@davideschiavone davideschiavone

Labels
Component:Verif For issues in the verification environment or test cases (e.g. for testbench, C code, etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YoannPruvost @davideschiavone