Fix createsuperuser/changepassword #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue comes from the User, InteractiveUser and TechnicalUser all inheriting from the base AbstractUser and having a _u delegation. This means that Django cannot guess from User that it has to request a password when using createsuperuser. So we're allowing an empty password by default. This obviously requires to set the password in a second command. The changepassword was not working either because when setting the password, it was properly delegated to the underlying TechnicalUser but that user was not saved, only User. I therefore added a save() function to delegate the saving of the underlying object if it had already been created (it has an id).
xgill
approved these changes
Jul 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue comes from the User, InteractiveUser and TechnicalUser all inheriting from the base AbstractUser and having a _u delegation. This means that Django cannot guess from User that it has to request a password when using createsuperuser. So we're allowing an empty password by default.
This obviously requires to set the password in a second command. The changepassword was not working either because when setting the password, it was properly delegated to the underlying TechnicalUser but that user was not saved, only User. I therefore added a save() function to delegate the saving of the underlying object if it had already been created (it has an id).
I am a bit afraid of side effects with the auto provisioning of users and other use cases.