Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CM-162: improve custom filter applying into queryset in query and exports #191

Merged
merged 4 commits into from
Jun 21, 2023
Merged

CM-162: improve custom filter applying into queryset in query and exports #191

merged 4 commits into from
Jun 21, 2023

Conversation

sniedzielski
Copy link
Contributor

@dborowiecki
Copy link
Contributor

@sniedzielski I see there are issues with CI, can you resolve them?

@sonarcloud
Copy link

sonarcloud bot commented Jun 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sniedzielski
Copy link
Contributor Author

@dborowiecki Fixed by this commit b03d2a8 .
Let me know if there is a better solution to fix this. Maybe we should order 'nose' to ignore running such test helpers as test. For me it looks like those helpers are treated as 'test cases' because of having 'test' substring in the name of those methods.

@dborowiecki dborowiecki merged commit 0451f93 into develop Jun 21, 2023
@dborowiecki dborowiecki deleted the feature/CM-162 branch June 21, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dborowiecki dborowiecki dborowiecki approved these changes

@malinowskikam malinowskikam Awaiting requested review from malinowskikam

@jdolkowski jdolkowski Awaiting requested review from jdolkowski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sniedzielski @dborowiecki