ONI-132: Changing mutation code to handle autogeneration. #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malinowskikam
requested changes
Aug 10, 2023
core/schema.py
Outdated
Comment on lines
266
to
278
| if mutation_data.get('autogenerate_code', None): | ||
| returned = cls.async_mutate(info.context.user if info.context and info.context.user else None, | ||
| **mutation_data) | ||
|
|
||
| if isinstance(returned, Dict): | ||
| data.update(returned) | ||
| error_messages = None | ||
| else: | ||
| error_messages = returned | ||
| else: | ||
| error_messages = cls.async_mutate( | ||
| info.context.user if info.context and info.context.user else None, | ||
| **mutation_data) |
There was a problem hiding this comment.
This code can be expressed as:
Suggested change
| if mutation_data.get('autogenerate_code', None): | |
| returned = cls.async_mutate(info.context.user if info.context and info.context.user else None, | |
| **mutation_data) | |
| if isinstance(returned, Dict): | |
| data.update(returned) | |
| error_messages = None | |
| else: | |
| error_messages = returned | |
| else: | |
| error_messages = cls.async_mutate( | |
| info.context.user if info.context and info.context.user else None, | |
| **mutation_data) | |
| messages = cls.async_mutate(info.context.user if info.context and info.context.user else None, **mutation_data) | |
| if mutation_data.get('autogenerate_code', False) and isinstance(messages, Dict): | |
| data.update(messages) | |
| error_messages = None | |
| else: | |
| error_messages = messages |
|
Kudos, SonarCloud Quality Gate passed!
|
This was referenced Aug 18, 2023
ghost
marked this pull request as ready for review
dborowiecki
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket:https://openimis.atlassian.net/browse/ONI-132
Changes: