CM-296: add additional params to the custom filters #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
dborowiecki
approved these changes
Oct 3, 2023
There was a problem hiding this comment.
It looks good, I'd avoid unpacking tuple with so many arguments like in
module_name, object_type_name, uuid_of_object, additional_params = Query._obtain_params_from_custom_filter_graphql_query(**kwargs),
but I see that it was used previously so I wouldn't suggest changing it right now.
dragos-dobre
added a commit
that referenced
this pull request
Oct 18, 2023
* CI update * CI Update 2 * ONI-104: Block logging if HF contract expired. (#215) * ONI-104: Block logging if HF conract expired. * ONI-104: Changed default setting for HF status login. * ONI-104: Code review changes in HF contract login check. * CM-296: add additional params to the custom filters (#218) Co-authored-by: Jan <j.dolkowski@soldevelo.com> * Better helpers (#219) * cache-user-disctrict * fix * better helper * ONI-174: Fix updating user. (#220) * Deactivate cache on service (#221) * hotfix user save * ONI-174: Add util to remove permission from a role. (#223) * update cache rights (#225) --------- Co-authored-by: Damian Borowiecki <dborowiecki@soldevelo.com> Co-authored-by: Jan <jdolkowski@soldevelo.com> Co-authored-by: wzglinieckisoldevelo <98958634+wzglinieckisoldevelo@users.noreply.github.com> Co-authored-by: Jan <j.dolkowski@soldevelo.com> Co-authored-by: Patrick Delcroix <patrick.delcroix@swisstph.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://openimis.atlassian.net/browse/CM-296
This PR adds ability to use additional params with custom filters.