Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ONI-104: Draft for new auth system. #224

Merged
merged 3 commits into from
Jan 16, 2024
Merged

ONI-104: Draft for new auth system. #224

merged 3 commits into from
Jan 16, 2024

Conversation

ghost
Copy link

@ghost ghost commented Oct 11, 2023 •
edited by ghost
Loading

Ticket: https://openimis.atlassian.net/browse/ONI-104

FE PR: openimis/openimis-fe-core_js#158

Changes:

  • Error code now sent to frontend
  • Frontend now can show different messages for different reasons of discarding authentication

@sonarcloud
Copy link

sonarcloud bot commented Oct 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ghost ghost mentioned this pull request Jan 10, 2024
Merged
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 10, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

2 Security Hotspots
16.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@ghost ghost requested review from dborowiecki and sniedzielski January 10, 2024 17:42
@ghost ghost marked this pull request as ready for review January 10, 2024 17:43
@dragos-dobre dragos-dobre merged commit 72cdd35 into develop Jan 16, 2024
5 of 12 checks passed
@dragos-dobre dragos-dobre deleted the feature/ONI-104-1 branch January 16, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dborowiecki dborowiecki Awaiting requested review from dborowiecki

@sniedzielski sniedzielski Awaiting requested review from sniedzielski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dragos-dobre @wzgliniecki