OFS-88: migrating base mutations and delete/replace input types to the Core"module" #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 3 alerts when merging 4bf13b5 into 6c54b70 - view on LGTM.com new alerts:
|
delcroip
approved these changes
Dec 1, 2020
delcroip
requested changes
Dec 1, 2020
dragos-dobre
approved these changes
Dec 1, 2020
|
Please solve the alerts from lgtm-com. |
|
Ok @delcroip and @dragos-dobre - I've fixed this issue in this repo. I only have to fix on "PolicyHolder" repo with folder name. |
|
This pull request introduces 1 alert when merging ad31d5e into 6c54b70 - view on LGTM.com new alerts:
|
delcroip
approved these changes
Dec 1, 2020
dragos-dobre
approved these changes
Dec 1, 2020
|
This pull request introduces 1 alert when merging 239bbdd into 6c54b70 - view on LGTM.com new alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In that pull request I want to include base mutations on "Core" module. It was checked on PolicyHolder module and for that ticket there is another pull request. The link will be below this description. The changes in another modules connected with that issue will be visible during working on them (for example contribution plan, contract etc)
The pull request on "PolicyHolder" module openimis/openimis-be-policyholder_py#4