OFS-285: changes regarding bulk action for FS entities #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e_py into feature/OFS-285
delcroip
approved these changes
Apr 30, 2021
| .objects \ | ||
| .filter( | ||
| Q(date_valid_from=None) | Q(date_valid_from__lte=now), | ||
| Q(date_valid_to=None) | Q(date_valid_to__gte=now) |
There was a problem hiding this comment.
Q(date_valid_from=None) | Q(date_valid_from__lte=now),
change it to
Q(date_valid_from__lte=now),
| return_objects: bool = False): | ||
| """ | ||
| dedicated extended mutaion from flter decorator dedicated for Formal Sector entities. See doc string for | ||
| mutation_on_uuids_from_filter to read more how this works. |
There was a problem hiding this comment.
please mention GistoryModel BusinessHistoryModel instead for FS (I hope that those model will be used in the future by other)
There was a problem hiding this comment.
ok, I can rename also this decorator to not use "fs". I will rename to "history_model"
core/gql/gql_mutations/__init__.py
Outdated
| @@ -1,3 +1,3 @@ | |||
| from .input_types import * | |||
| from .exceptions import ObjectNotExistException, MutationValidationException | |||
| from .mutation_by_filter import mutation_on_uuids_from_filter | |||
| from .mutation_by_filter import mutation_on_uuids_from_filter, mutation_on_uuids_from_filter_fs | |||
delcroip
approved these changes
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TICKET: https://openimis.atlassian.net/browse/OFS-285