Security fix for Django order_by flaw #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details: GHSA-xpfp-f569-q3p2 The proper way to address this would be to upgrade Django to 3.1.13 but it requires to update all the JSONField (and convert the NullBooleanField to BooleanField). While the JSONField seems to work when we remove the JSONFallback component, the boolean field does not work anymore with `bit` data types. They are compared with the boolean instead of 0 or 1. I tried to check for updates on the mssql driver but it seems not to have moved in a long while. I have therefore implemented the same kind of fix as the 3.1.13 did, right into the OrderedDjangoConnectionField...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details: GHSA-xpfp-f569-q3p2
The proper way to address this would be to upgrade Django to 3.1.13 but it requires to update all the JSONField (and convert the NullBooleanField to BooleanField). While the JSONField seems to work when we remove the JSONFallback component, the boolean field does not work anymore with
bitdata types. They are compared with the boolean instead of 0 or 1.I tried to check for updates on the mssql driver but it seems not to have moved in a long while.
I have therefore implemented the same kind of fix as the 3.1.13 did, right into the OrderedDjangoConnectionField...