Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add red star to required gokb-select-field labels (GOKbIT-410) #118

Merged
merged 2 commits into from
Feb 7, 2023
Merged

Add red star to required gokb-select-field labels (GOKbIT-410) #118

merged 2 commits into from
Feb 7, 2023

Conversation

philboeselager
Copy link
Contributor

No description provided.

hornmo
hornmo requested changes Feb 7, 2023
View reviewed changes
Copy link
Collaborator

@hornmo hornmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For completions sake, edit-title-view should be adjusted so that isValid checks for the currentType as well and the default submit should be :disabled="!isValid".

@hornmo hornmo merged commit d53f1e6 into develop Feb 7, 2023
@hornmo hornmo deleted the 410-mandatoryTitleType branch June 19, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hornmo hornmo hornmo approved these changes

Assignees

@hornmo hornmo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philboeselager @hornmo